[perl #125786] [PATCH] Improve handling of subclasses and mixed object classes in Math-BigInt

[Peter J. Acklam) (via RT]

# New Ticket Created by (Peter J. Acklam)
# Please include the string: [perl #125786]
# in the subject line of all future correspondence about this issue.
# <URL: https://rt.perl.org/Ticket/Display.html?id=125786 >


The attached patch contains various improvements for Math-BigInt's handling of subclasses and improve how Math-BigInt works with other numerical object classes. This patch will also make Math-BigInt-Lite work again (finally!).

[James E Keenan via RT]

Post by Peter J. Acklam) (via RT
The attached patch contains various improvements for Math-BigInt's
handling of subclasses and improve how Math-BigInt works with other
numerical object classes. This patch will also make Math-BigInt-Lite
work again (finally!).

I don't see any patch attached. Can you re-try?

Thank you very much.

[(Peter J. Acklam) via RT]

Post by James E Keenan via RT
I don't see any patch attached. Can you re-try?

Hopefully, the patch is attached this time.

---
via perlbug: queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=125786

[Tony Cook via RT]

Post by (Peter J. Acklam) via RT

Post by James E Keenan via RT
I don't see any patch attached. Can you re-try?

Hopefully, the patch is attached this time.

Thanks, there's a few minor issues:

- the new test files are marked executable, which perl's tests complain about

- MANIFEST wasn't updated

- there's a broken link:

This loses precision, to avoid this use L<as_int()> instead.

at line 4401 dist/Math-BigInt/lib/Math/BigInt.pm, which should be L</as_int()>.

These were all picked up by running:

make test_porting

which the full test suite also runs.

Given you're doing all the maintenance and doing the releases to CPAN, have you considered making MBI CPAN upstream?

Tony

---
via perlbug: queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=125786